Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove test if dest file exist on path_rename wasi syscall (for #3228) #3230

Merged
merged 12 commits into from
Oct 18, 2022
Merged

Remove test if dest file exist on path_rename wasi syscall (for #3228) #3230

merged 12 commits into from
Oct 18, 2022

Conversation

ptitSeb
Copy link
Contributor

@ptitSeb ptitSeb commented Oct 14, 2022

Description

The test was added "just in case", but is not conforment with WASI spec, were path_rename should befave like POSIX renameat

@ptitSeb ptitSeb requested a review from syrusakbary October 14, 2022 12:53
syrusakbary
syrusakbary requested changes Oct 17, 2022
View reviewed changes
Copy link
Member

@syrusakbary syrusakbary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to add a test verifying this is fixed

@ptitSeb ptitSeb requested a review from syrusakbary October 17, 2022 10:43
Michael-F-Bryan
Michael-F-Bryan reviewed Oct 18, 2022
View reviewed changes
Copy link
Contributor

@Michael-F-Bryan Michael-F-Bryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

We've already discussed most of my comments over Zoom and I'm happy with the PR. There are a couple suggestions, but they're mostly cosmetic changes.

lib/vfs/src/mem_fs/filesystem.rs Outdated Show resolved Hide resolved
lib/wasi/src/syscalls/mod.rs Outdated Show resolved Hide resolved
lib/wasi/src/syscalls/mod.rs Show resolved Hide resolved
lib/wasi/src/syscalls/mod.rs Show resolved Hide resolved
lib/wasi/src/syscalls/mod.rs Outdated Show resolved Hide resolved
tests/wasi-wast/wasi/tests/path_rename.rs Outdated Show resolved Hide resolved
tests/wasi-wast/wasi/tests/path_rename.rs Outdated Show resolved Hide resolved
tests/wasi-wast/wasi/tests/path_rename.rs Show resolved Hide resolved
@syrusakbary syrusakbary mentioned this pull request Oct 18, 2022
Closed
@syrusakbary syrusakbary merged commit 497cedf into master Oct 18, 2022
@bors bors bot deleted the fix_wasi_path_rename branch October 18, 2022 18:45
@Michael-F-Bryan Michael-F-Bryan mentioned this pull request Oct 25, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Michael-F-Bryan Michael-F-Bryan Michael-F-Bryan approved these changes

@syrusakbary syrusakbary syrusakbary approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ptitSeb @syrusakbary @Michael-F-Bryan